C++ Type text editor not working..Code inside! - Overclock.net

Pooping^fish · 11-13-07

Code:

#include <cstdlib>
#include <iostream>
#include <fstream>
using namespace std;

int main(int argc, char *argv[])
{
   cout<<"Enter File Name: ";
   string file_name;
   cin>>file_name;
   cout<<"Enter text to be written inside the file: ";
   string text;
   cin>>text;
   fstream file(file_name, ios::out);
   file<<text<<endl;
   
   
    system("PAUSE");
    return EXIT_SUCCESS;
}

Its supposed to have them enter the name of the file, then it asks what they want inside the file.
Currently the first fstream line is highlighted..Any ideas?

Thankyou guys! +REP for any help or advice!

tehpwnerofn00bs · 11-13-07

can't you just set "file" equal to "text"?

Pooping^fish · 11-13-07

What the first fstream line there is suposed to do is get the specified name from the user and use that to title or name the file, the next with "text" adds the text the user enters into the file to be saved. So I dont think thatd work..=(

kdbolt70 · 11-13-07

One thing you need to do is set up the ofstream properly, and you need to pass the filename as a c-string.

Code:

ofstream file;
file.open(file_name.c_str());

Also, cin >> text will delimit at the first space, so if you wanted to input "Happy Birthday", it will only write "Happy" to file. You can try using the

Code:

getline(cin, text);

function.

There may be a better way of doing this, but I just threw this together real quick so you can see what I did. Notice calling the getline twice, because it needs to flush the input buffer:

Code:

#include <iostream>
#include <string>
#include <fstream>
using namespace std;

int main(int argc, char *argv[])
{
   cout<<"Enter File Name: ";
   string file_name;
   cin>>file_name;
   ofstream file;
   file.open(file_name.c_str());//opens file with c-string cast
   cout<<"Enter text to be written inside the file: ";
   string text;
   getline(cin, text); //flushes newline from previous read
   getline(cin, text);
   
   file<<text<<endl;
   
    system("PAUSE");
    return EXIT_SUCCESS;
}

Edit: if you want to read more than just one line to the file, you may want to use a while loop to keep reading and writing.

Pooping^fish · 11-13-07

I messed with it some and it compiled, got me to enter name, then when it asked for text it added push any key to close right after..
Can you put it in and give me the full code example so I know what this should look like or where the lines actually go or what they replace? Still very new.

kdbolt70 · 11-13-07

Quote:

Originally Posted by Pooping^fish

I messed with it some and it compiled, got me to enter name, then when it asked for text it added push any key to close right after..
Can you put it in and give me the full code example so I know what this should look like or where the lines actually go or what they replace? Still very new.

Just did that as an edit, hope that helps. Its a bit confusing with the psuedo-cast to a c string, and the two getline calls. The reason it takes a c-string rather than a c++ string is because the string class is not implemented in C, so trying to open a file with a string filename would make no sense.

The reason it is not recognizing the getline is because the "enter" (aka newline '\n') you put into the input buffer is not read on the initial cin when you get filename. Every time you input something and hit enter, a newline character gets put into the input stream. If a function delimits on that newline, which is what cin does, it will leave the newline in the input stream. The next thing to read from the input will suddenly get a newline right away, because it is the first thing there. So it is sitting in the input buffer, and when you call getline from the cin stream, it writes that newline to text and thinks it has done its job. so doing it twice clears that newline you input earlier, and reads the next stuff from the input buffer.

Pooping^fish · 11-13-07

Thanks man, it worked! Trying to look at it to see what alls been done here.
Most of what you said went right over my head though. But I'll learn!

*dangerousHobo* · 11-13-07

Cool I learned two new things too! (*crawls back to java wishing he knew c++ better*)

kdbolt70 · 11-13-07

Quote:

Originally Posted by dangerousHobo

Cool I learned two new things too! (*crawls back to java wishing he knew c++ better*)

Heh, I'm glad! Don't you worry. I'll be calling on you in a few days when I have to write my first interactive Java GUI using swing **shudders and runs back to C++**

Also 'fish, the line

Code:

system("PAUSE");

tells me that you are using the Dev-C++ Editor by Bloodshed, am I correct? You may want to remove it from your final program, as it is technically not needed. The geniuses that made Dev-C++ (I use the term loosely) decided if main returns, they should automatically close the console, which is somewhat counterintuitive. Just letting you know.

Kirmie · 11-13-07

The reason that the console applications close immediately after the program finishes main is that if you run this program from a command line the program immediately goes back to the command line. It would be one big pain if you had to explicitly tell your program to exit and go back to a command line since most programs run in the console typically don't require much, if any, user input.

		Overclock.net - Overclocking.net > Software, Programming and Coding > Coding and Programming > Application Programming
C++ Type text editor not working..Code inside!

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)