version2

It's funny how I spend my time reading code rather than compiling it...

It looks, overall, like relatively simple code, but a good way to learn and expand upon the C++ language. Now I'm just starting to learn C++ myself.

majin death

Looks to be a couple of number converters.

__________________
When will JAGeX and Valve work together to make the perfect game?

rubendodge

K I uploaded the EXE to the boar din my first post. Enjoy guys . Also I'm beta testing / coding a Information saver to save friends numbers,names, etc since I seen it on this board and thought coding one into this program would be awesome .

Pooping^fish

Hah, that was probably mine.

__________________
Proud Member of the Linux Gaming Community
I am your friend.

Sgt.Collins

that is cool! i want to start learning that now

__________________

redsox83381

Ha those are those fun little programs you learn in the first few months. Cool to see them all together like that.

__________________

E6300 @ 3.5 Proof

Licht

Buddy, switch statements! I believe that would help you a great deal.

__________________

Greater Data Compression - The Ultimate Web Security Tool
---C#--- DoubleMark, Stress and Test Any Number of Cores! ---C#---
Want to learn how to program? A beginner's guide for the common man.
Visit the Coding && Programming Section

kdbolt70

one thing I noticed in the 7 seconds I scanned it, you have no error checking. If the user inputs "banana" as their menu choice, your program isn't going to do anything. I'd A) have a default: statement in your switch statement so if any thing comes through that isn't 1-15, it will print an error and run it again. B) I'd probably make some sort of error checking function that returned true or false if the input was acceptable. Lastly, I'd run that switch statement in a while loop, so people can use more than 1 of your functions when they use the program.

Let me know if you have any questions.

__________________

Scriptorum

Nice program! Now refactor it. Refactoring is changing your code so that it makes adding future functionality EASIER and FASTER.

1. Take everything inside of each case statement and move it to its own function. That's 13-14 functions for you.

2. Look for sets of two of more functions that have similar behavior and vary slightly, then merge each set into a single function using parameters to achieve the varying behavior.

For example, don't the dog years and cat years calculations look similar? What varies between those two snippets? Can you think of how to make a single function with parameters that could calculate dog or cat years AND takes less code than your current implementation?

3. If you're really feeling hopped up and want to try something advanced with classes, now take a look at that switch. Any time you see a big switch you should think about encapsulating what varies. What if you created a "command" object for each function and corresponding English description? (For instance, FibonacciCommand.invoke() writes the Fibonacci sequence to a file. FibonacciCommand.getDescription() returns "Fibonacci Sequence". FibonacciCommand, then, is one of several classes that implements or extends Command, which is either an abstract class or interface that enforces the implementation of invoke and getDescription, and gives your main program a common TYPE to deal with.) Now you can create new instances of the command objects and store them in an array. Loop through the array to print out your menu. When you receive input, look up the object from the array based on the number entered, and invoke the command from said object. Adding more commands to your program is simply creating a new command class and adding an instance of it to the array.

This last kind of refactoring creates a lot of new classes, so it's work with little short term value to show for it. However, it pays off in the long run if you continue to develop this into a large application. The first two refactorings, however, make your code shorter, particularly your main function (which is huge), and makes everything easier to read. A good rule of thumb is if you can't see the entire function on screen at once, it needs to be broken up into smaller functions.

And of course, what was said previously about error checking is totally correct. Error checking good.

__________________

rubendodge

Ok I will work on adding some of these ideas. The only real problem is the whole thing about making it be able to restart the app after a operation. I've never done it before so I'm still newbie lol.