If-else and return - Overclock.net

The Bartender Paradox · 08-15-08

This a simple thing that has been bothering me for a bit in C++.

Say I have a function with multiple return points, controlled by an If statement. Which is better, or is it just a matter of style:

Code:

if(condition)
{
    return value;
}
else
{     
    rest of function involving more return statements
}

or

Code:

if(condition)
{
    return value;
}

rest of function involving more return statements

They both do the same thing, but the second option saves me a couple of lines of code and from having to indent the rest of the function. Any reason not to do it?

JoBlo69 · 08-15-08

unless you have an else statement, there is no need to put it there...

If is true, return value... Else return another value. If you only have one value to return, you can ignore the else part...

Question:

Why use on if then if you only have one return value?

The Bartender Paradox · 08-15-08

Quote:

Originally Posted by JoBlo69

unless you have an else statement, there is no need to put it there...

If is true, return value... Else return another value. If you only have one value to return, you can ignore the else part...

Question:

Why use on if then if you only have one return value?

Sorry, there are more return statements later on in the function, I'll try to make that more clear in the OP. Like for example, if there are invalid arguments supplied to the function return -1 otherwise continue on with the function normally.

rabidgnome229 · 08-15-08

I would do the latter. They will result in identical assembly, but the second option reduces the amount of indentation. If you have a lot of nested conditionals/loops it can be easy to lose track of what level you're on (as somebody reading the code), so the latter is a bit more readable.

mrtn400 · 08-15-08

Quote:

Originally Posted by The Bartender Paradox

This a simple thing that has been bothering me for a bit in C++.

Say I have a function with multiple return points, controlled by an If statement. Which is better, or is it just a matter of style:

Code:

if(condition)
{
    return value;
}
else
{     
    rest of function involving more return statements
}

or

Code:

if(condition)
{
    return value;
}

rest of function involving more return statements

They both do the same thing, but the second option saves me a couple of lines of code and from having to indent the rest of the function. Any reason not to do it?

I would still use else, because it would be easier to debug IMO.

Quote:

Originally Posted by rabidgnome229

I would do the latter. They will result in identical assembly, but the second option reduces the amount of indentation. If you have a lot of nested conditionals/loops it can be easy to lose track of what level you're on (as somebody reading the code), so the latter is a bit more readable.

They compile the same?

Shows how much of a C++ nub I am. :|

Edit: Ooohhh! I get it now. I kind of forgot that if the first if statement is ran, the program quits.

(Note: I haven't touched anything coding for a year or so, and I'm waaay out of my coding mindset.)

*dangerousHobo* · 08-15-08

If it was me, I'd go the second way. Just cleaner IMO.

Drakemoore · 08-15-08

First version for debugging. Although switches seem to be a bit better if you need more branching.

rabidgnome229 · 08-16-08

Quote:

Originally Posted by Drakemoore

First version for debugging. Although switches seem to be a bit better if you need more branching.

Yeah, but switch only takes constant expressions. You can't do < > conditionals cleanly

		Overclock.net - Overclocking.net > Software, Programming and Coding > Coding and Programming > Application Programming
If-else and return

08-15-08	#7 (permalink)
Drakemoore Overclocker Join Date: Dec 2007 Location: Florida Posts: 198 Rep: 9 Unique Rep: 9 Trader Rating: 0	First version for debugging. Although switches seem to be a bit better if you need more branching.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)