hsmith1976

I have this assignment and I have been able to declare an array but I need the information from the array to print(i.e user puts in 7 digits i need to list the 7 digits in a column. My code is below any assistance would be great.

#include <iostream>
#include <math.h>

using namespace std;

int main()
{
int n, count;
float x = 0, sum = 0, mean = 0, var = 0, sd = 0;



cout << "How many numbers? ";

cin >> n;

int mainnum[n];
for (count = 1; count <= n; count++) {
cout << "? ";
cin >> x;
mainnum[count-1] = n
;

sum = sum + x;

} // end for

mean = sum / n;

cout << "You have entered the following:" << endl;

cout << mainnum[n] << "\r\n";

cout << "The sum is " << sum << endl;

cout << "The meann is " << mean << endl;

system("PAUSE");
return 0;
}

mrtn400

You want the same thing as that, but opposite.

__________________

hsmith1976

Not sure what you mean by that or where to even put that in at.

ocnjk

i'm guessing you are trying to input each digit one by one into the mainnum array?

The way you have it now is just filling up the array with the total number of digits that the user wants to input (the variable n).

So instead it should be:
Also instead of doing [count-1] you can change the for loop to be the following so that you can use the line of code i wrote above.
The reason is because arrays start with position 0. The loop will be performed while count is less than n. Let's say n is 3, the loop will run for count = 0, 1, 2.

To print it in a single column, you can pretty much reuse the same format as the for loop you created to fill the array. Instead of asking/inserting the digit into the array, just cout each array element followed by endl;

hsmith1976

That doesn't really do what I want either. I need the list to go below the portion of the program below.


#include <iostream>
#include <math.h>

using namespace std;

int main()
{
int n, count;
float x = 0, sum = 0, mean = 0, var = 0, sd = 0;



cout << "How many numbers? ";

cin >> n;

int mainnum[n];
for (count = 1; count <= n; count++) {
cout << "? ";
cin >> x;
mainnum[count-1] = n
;

sum = sum + x;

} // end for

mean = sum / n;

cout << "You have entered the following:" << endl;

and the out put needs to look something like
12
34
32
65
87
54

ocnjk

It actually does, maybe you aren't understanding what I wrote.

I'll be nice and give you the code (you add this at the end of the code after the "you have entered..." line).

for(int i = 0; i < n; ++i){
cout << mainnum[i] << endl;
}

But I hope you can understand when using for loop with array, you should use initial counter at 0 instead of 1 and that you need to fix the part where you are inputting each number into the array.

hsmith1976

Thanks let me try this and I will get back with you.

jpz

As already pointed out, you need to print each digit(more specifically each element of the array) individually. For example, you would first print mainnum[0], then print mainnum[1]... print mainnum[n-1]. Instead of writing seven separate print statements, you could print all the digits with a for loop similar to the one you used to get the input.

I'd also like to point out this line of code:

mainnum[n] is invalid because the last element in the array has a length of n and is zero-indexed. mainnum[n] points to a space of memory after the last digit in your array, which you should not try to access.

EDIT:

His code is perfectly valid. Some people like to use an initial value of 1 and other people like to start from 0. Starting at 1 is easier for some people to understand and it can make the code easier to read(for some). There is no need to change it.

__________________

hsmith1976

Thanks for the information that part works now I just need to finish the program by adding the digits of the array together. Maybe back with you later for help with that but I am working on it.

ocnjk

I never said it wasn't valid.

Yes, it does work, but he is making the program execute an unnecessary operation. He may get away with it in a beginner's class, but it won't fly in more advanced classes (if you get a decent professor). It is better to get in the habit of properly coding early instead of later on.