C# Doesn't like my Else's - Overclock.net

Starbuck5000 · 10-12-09

So started working on a "Vending Machine" program in C# however All of my else's get flagged. I realise that you can use the switch function instead but before i start changing it I'd like to get to the bottom of why I am getting this error.

Cheers

Daney · 10-12-09

= is used for writing
== is used for reading.

Change the = in the Else's/If's to == and it should be fine and dandy, good luck

Edit: You should also use "C" to check if it's C.

Starbuck5000 · 10-12-09

Quote:

Originally Posted by Daney

= is used for writing
== is used for reading.

Change the = in the Else's/If's to == and it should be fine and dandy, good luck

Edit: You should also use "C" to check if it's C.

Cheers

What do you meant by use "C"

Edit: Tried it and the red "squiggle" is only at the end of the Order == bit like its expecting a ;
My else's are still flagged with squiggles.

It says "Invalid expression term 'else'" and "; expected"

**BiG O** · 10-12-09

Also, you should be using 'else if's, not else's

Also, if you're checking for a string...ie. "C", you may need to use .equals("C") rather than ==.

example:

if c
do this

else if d
do this

else if e
do this

else
do this

That's extremely vague, but hopefully you get the idea.

Daney · 10-12-09

Quote:

Originally Posted by BiG O

Also, you should be using 'else if's, not else's

Also, if you're checking for a string...ie. "C", you may need to use .equals("C") rather than ==.

example:

if c
do this

else if d
do this

else if e
do this

else
do this

That's extremely vague, but hopefully you get the idea.

Wow, how did I forget that?

But yeah; he's right (Don't rep me for this btw

)

killnine · 10-12-09

You will have to use character literals for what you are equating to your variable Order:

Quote:

if (Order == 'C')
{
//do something here
}

otherwise, right now you are saying "set the variable Order equal to the variable C", which you haven't declared.

Also, instead of hardcoding 'C', T, O, H in there, you can declare constants at the top of your file and change what character the user may put in down the road:

Quote:

CONST char COFFEE = 'C';
CONST char TEA = 'T';
CONST char ORANGE_JUICE = 'O';
CONST char HOT_CHOCOLATE = 'H';

.
.
.

if (Order == COFFEE)
{
//do something
}

decompiled · 10-12-09

== checks if objects are equal. ObjectA == ObjectB. Do they use the same memory address.

.equals() for string values is checking to see if the characters match.

Finally as posted above. = is used for assignment.

**BiG O** · 10-12-09

Quote:

Originally Posted by killnine

You will have to use character literals for what you are equating to your variable Order:

otherwise, right now you are saying "set the variable Order equal to the variable C", which you haven't declared.

Also, instead of hardcoding 'C', T, O, H in there, you can declare constants at the top of your file and change what character the user may put in down the road:

He doesn't have to do that. He can just use .equals() to check the strings themselves.

Starbuck5000 · 10-12-09

Tried adding "else if" however its now saying that I have a "use of unassigned local variables"

Quote:

Originally Posted by killnine

You will have to use character literals for what you are equating to your variable Order:

otherwise, right now you are saying "set the variable Order equal to the variable C", which you haven't declared.

Also, instead of hardcoding 'C', T, O, H in there, you can declare constants at the top of your file and change what character the user may put in down the road:

Like this

cathode · 10-12-09

no, declare the constants at the class level not in the method.

like this:

Code:

public class VendingMachine
{
  private const char COFFEE = 'C';
}

I'm not trying to sound condescending here but you should really invest some time in reading some beginner guides to C# because they go over all this kind of stuff.

		Overclock.net - Overclocking.net > Software, Programming and Coding > Coding and Programming > Application Programming
C# Doesn't like my Else's

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)