[C++] Class code consolidation? - Overclock.net

Microsis · 06-20-08

I'm about to throw the following class into it's own header file...

I was just wondering if there are any changes i should make (consolidating etc.) you c++ gurus would recommend.

Also, just making sure my uses of inline and const are correct.

Code:

class Mob
{
public:
     Mob(int hp = 50, string name = "Giant Roach", int attack = 9); //if nothing is set, default to 50

     int getHP() const;
     string getName() const;
     int getAttack() const;
     bool dmg(int& dmg);
     int attack(int& playerHP);
private:
     int m_HP;
     string m_Name;
     int m_Attack;
};

Mob::Mob(int hp, string name, int attack):
             m_HP(hp),
             m_Name(name),
             m_Attack(attack)
{
     cout << "t--" << getName() << " created with " << getHP() << " HP" << endl << endl;
}
inline int Mob::getHP() const
{
     return m_HP;
}
inline string Mob::getName() const
{
     return m_Name;
}
inline int Mob::getAttack() const
{
     return m_Attack;
}
inline int Mob::attack(int& playerHP)
{
     playerHP -= getAttack();
     cout << "t" << getName() << " attacks you for " << getAttack() << " damage" << endl;
     cout << "tYou now have " << playerHP << " HP" << endl << endl;
     return playerHP;
}
inline bool Mob::dmg(int& dmg)
{
     m_HP -= dmg;  
     cout << "tYou deal " << dmg << " damage!" << endl;
     if (m_HP <= 0) //killing blow
     {
          m_HP = 0; cout << "tYou killed " << getName() << "!" << endl << endl;
          return 0;
     }
     else //non-killing blow
     {
          cout << "t" << getName() << " now has " << getHP() << "HP" << endl << endl;
          return 1;
     }
}

rabidgnome229 · 06-20-08

You only really want to use inline for very short methods. What it means is that when the compiler comes upon a call to that function, it replaces the function call with just the code that the method contains. So in the compiled program, everywhere that getHP is called, there is no actual function call, just the equivalent of "return m_HP." There is overhead associated with a function call, so for very short functions like that one it improves performance to make it inline. If you use inline for a function such as Mob::dmg, it will also replace all calls to Mob::dmg with the code for it. Since this is a longer function, that will make your compiled program much bigger.

You can use inline for all of them, but I would suggest only using inline for one or two line functions

Butterbum · 06-21-08

Quote:

Originally Posted by rabidgnome229

You only really want to use inline for very short methods. What it means is that when the compiler comes upon a call to that function, it replaces the function call with just the code that the method contains. So in the compiled program, everywhere that getHP is called, there is no actual function call, just the equivalent of "return m_HP." There is overhead associated with a function call, so for very short functions like that one it improves performance to make it inline. If you use inline for a function such as Mob::dmg, it will also replace all calls to Mob::dmg with the code for it. Since this is a longer function, that will make your compiled program much bigger.

You can use inline for all of them, but I would suggest only using inline for one or two line functions

To be honest. The compiler is much better at choosing inline functions than a programmer. I would not set any as inline, let the compiler do it, that's its job. Also, you aren't putting the functions into that header file as well are you? If you are, i would recommend doing so like this.

Code:

class foo {

    public:
 
        void pie(int blah)
        {
               cout<<"I like pie";
        }


}

^^ Should be correct with GCC. But its late so meh.

Another thing to think about, is creating a standard entity class that most other classes are derived from. Its a fair amount of work, but it pays off in the end big time.

Microsis · 06-22-08

Quote:

Originally Posted by Butterbum

Another thing to think about, is creating a standard entity class that most other classes are derived from. Its a fair amount of work, but it pays off in the end big time.

such as..

Code:

Class character
{
   int m_HP, m_ATK;
   //...
};

and then Class Mob and Class Player are childs of that (parent) class?

rabidgnome229 · 06-22-08

Quote:

Originally Posted by Microsis

such as..

Code:

Class character
{
   int m_HP, m_ATK;
   //...
};

and then Class Mob and Class Player are childs of that (parent) class?

That is good OO practice in general, but I believe that Butter was telling you to make a class analogous to java's Object class, so that even the generic character class would derive from it.

Mrzev · 06-22-08

Its been around 2-3 years since i was doing C++ stuff.... been doing web stuff latley...

I was wondering why you were unsing inline anyways. I dont remember needing to use inline with classes. i designed something like that. it was a 1v1 game where you allocate attributes and you select abilitys. I never used inline throughout the whole thing. Was a few hundred lines of code heh... kinda sad that i lost it.

Inline has its advantages and disadvantages. Just doesn't seem needed In my opinion. But then again im probably average or a little below average programmer.

Here is some more info on it.
http://www.parashift.com/c++-faq-lit...functions.html

Microsis · 06-22-08

Quote:

Originally Posted by Mrzev

Its been around 2-3 years since i was doing C++ stuff.... been doing web stuff latley...

I was wondering why you were unsing inline anyways. I dont remember needing to use inline with classes. i designed something like that. it was a 1v1 game where you allocate attributes and you select abilitys. I never used inline throughout the whole thing. Was a few hundred lines of code heh... kinda sad that i lost it.

Inline has its advantages and disadvantages. Just doesn't seem needed In my opinion. But then again im probably average or a little below average programmer.

Here is some more info on it.
http://www.parashift.com/c++-faq-lit...functions.html

yea i've been reading forums and most people recommend just letting the compiler decide when it will use a function as an inline or not.

Butterbum · 06-24-08

Quote:

Originally Posted by Microsis

such as..

Code:

Class character
{
   int m_HP, m_ATK;
   //...
};

and then Class Mob and Class Player are childs of that (parent) class?

Yea, i did mean an "object" class similar to Java's. But you could do this too, i would probably use the name entity. You would store stuff like position, image information etc in this class.

Like i said before, its best to leave the inline decision up to the compiler, unless you're writing the next AAA game, and performance is a serious issue. For all you know, the functions you're choosing as inline could effect the performance of the program negatively.

		Overclock.net - Overclocking.net > Software, Programming and Coding > Coding and Programming
[C++] Class code consolidation?

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)