Calling all Java/ Comp Sci Guru's - Overclock.net

-bl4ck- · 10-07-09

So I have no errors, but when I try to run after building this code, It does nothing? Any reason why? I am using netbeans to write my code, I know this is real basic but its my assignment. This is my code, +reps for help!

package jamesmills;

import javax.swing.JOptionPane;
import java.util.Scanner;

public class jamesmills
{

public static void main(String[] args)
{
Scanner input = new Scanner(System.in);
int Choice;
float Num1, Num2;

//numbers
JOptionPane.showInputDialog (null, "Enter your first Number");
Num1=input.nextFloat();
JOptionPane.showInputDialog (null, "Enter your second Number");
Num2=input.nextFloat();
//choice
JOptionPane.showInputDialog (null, "1.Addtion\n2.Subtraction\n.Multiplication\n.Divis ion\n5.Quit");
Choice=input.nextInt();

//decision
while (Choice!=5)
{
switch (Choice)
{
case 1: addNumbers(Num1,Num2);
break;
case 2: subNumbers(Num1,Num2);
break;
case 3: multiNumbers(Num1,Num2);
break;
case 4: divideNumbers(Num1,Num2);
break;
case 5: break;
}//end switch
}//end while

}//end void main

//methods for math
public static float addNumbers(float Num1, float Num2)
{
float Total;
Total=Num1+Num2;
return Total;
}

public static float subNumbers(float Num1, float Num2)
{
float Total;
Total=Num1-Num2;
return Total;
}

public static float multiNumbers(float Num1, float Num2)
{
float Total;
Total=Num1*Num2;
return Total;
}

public static float divideNumbers(float Num1, float Num2)
{
float Total;
Total=Num1/Num2;
return Total;
}

}//end class

pippolo · 10-07-09

The Scanner reads from the standard input (and waits that you write something into the console), but the text entered into the JOptionPane isn't connected to the standard input.
The function

Code:

JOptionPane.showInputDialog (null, "Enter your first Number");

returns the entered text as a String. You have to write a thing like this:

Code:

String result = JOptionPane.showInputDialog (null, "Enter your first Number");

and after:

Code:

int number = Integer.parseInt(result);

or

Code:

Scanner scanner = new Scanner(result);
int number = scanner.nextInt();

Lumas · 10-07-09

And as a couple of syntax things:

Division has an extra space and is not numbered
Multiplication is not numbered

I believe it is also good practice when you declare your variables to set them equal to 0.

-bl4ck- · 10-07-09

great got it working thanks

Black Magix · 10-08-09

I really wish we could preserve spacing on the forums....that was hard as hell to read >.<

hometoast · 10-08-09

Quote:

Originally Posted by Black Magix

I really wish we could preserve spacing on the forums....that was hard as hell to read >.<

You CAN if you wrap it in [ CODE] blocks

Code:

lsdkjf
            lsdkjf

godsgift2dagame · 10-09-09

Hey dude, click "QUOTE" on my post and take everything from [quote] on down and edit your post. That was truly horrendous on the eyes.

Quote:

Originally Posted by -bl4ck-

package jamesmills;

import javax.swing.JOptionPane;
import java.util.Scanner;

public class jamesmills
{

public static void main(String[] args)
{
Scanner input = new Scanner(System.in);
int Choice;
float Num1, Num2;

//numbers
JOptionPane.showInputDialog (null, "Enter your first Number");
Num1=input.nextFloat();
JOptionPane.showInputDialog (null, "Enter your second Number");
Num2=input.nextFloat();
//choice
JOptionPane.showInputDialog (null, "1.Addtion\n2.Subtraction\n.Multiplication\n.Divis ion\n5.Quit");
Choice=input.nextInt();

//decision
while (Choice!=5)
{
switch (Choice)
{
case 1: addNumbers(Num1,Num2);
break;
case 2: subNumbers(Num1,Num2);
break;
case 3: multiNumbers(Num1,Num2);
break;
case 4: divideNumbers(Num1,Num2);
break;
case 5: break;
}//end switch
}//end while

}//end void main

//methods for math
public static float addNumbers(float Num1, float Num2)
{
float Total;
Total=Num1+Num2;
return Total;
}

public static float subNumbers(float Num1, float Num2)
{
float Total;
Total=Num1-Num2;
return Total;
}

public static float multiNumbers(float Num1, float Num2)
{
float Total;
Total=Num1*Num2;
return Total;
}

public static float divideNumbers(float Num1, float Num2)
{
float Total;
Total=Num1/Num2;
return Total;
}

}//end class

rabidgnome229 · 10-09-09

I think this is what you meant

Code:

package jamesmills;

import javax.swing.JOptionPane;
import java.util.Scanner;


public class jamesmills
{


    public static void main(String[] args)
    {
        Scanner input = new Scanner(System.in);
        int Choice;
        float Num1, Num2;

        //numbers
        JOptionPane.showInputDialog (null, "Enter your first Number");
        Num1=input.nextFloat();
        JOptionPane.showInputDialog (null, "Enter your second Number");
        Num2=input.nextFloat();
        //choice
        JOptionPane.showInputDialog (null, "1.Addtion\n2.Subtraction\n.Multiplication\n.Divis ion\n5.Quit");
        Choice=input.nextInt();

        //decision
        while (Choice!=5)
        {
            switch (Choice)
            {
                case 1: addNumbers(Num1,Num2);
                        break;
                case 2: subNumbers(Num1,Num2);
                        break;
                case 3: multiNumbers(Num1,Num2);
                        break;
                case 4: divideNumbers(Num1,Num2);
                        break;
                case 5: break;
            }//end switch
        }//end while


    }//end void main

    //methods for math
    public static float addNumbers(float Num1, float Num2)
    {
        float Total;
        Total=Num1+Num2;
        return Total;
    }

    public static float subNumbers(float Num1, float Num2)
    {
        float Total;
        Total=Num1-Num2;
        return Total;
    }

    public static float multiNumbers(float Num1, float Num2)
    {
        float Total;
        Total=Num1*Num2;
        return Total;
    }

    public static float divideNumbers(float Num1, float Num2)
    {
        float Total;
        Total=Num1/Num2;
        return Total;
    }

}//end class

		Overclock.net - Overclocking.net > Software, Programming and Coding > Coding and Programming
Calling all Java/ Comp Sci Guru's

10-07-09	#3 (permalink)
Lumas PC Gamer Join Date: Oct 2008 Location: Arizona Posts: 32 Rep: 3 Unique Rep: 3 Hardware Reviews: 2 Trader Rating: 0	And as a couple of syntax things: Division has an extra space and is not numbered Multiplication is not numbered I believe it is also good practice when you declare your variables to set them equal to 0.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)