C++: Class Time - Overclock.net

Mikey122687 · 2 Weeks Ago

PHP Code:


			
#include <iostream>
#include <ctime>
using namespace std;



class Time
{
public:
    int hour;
    int minute;
    int second;
    int time;

    Time()
    {
        time = time(0);
    }

    Time(int newTime)
    {
        time = newTime;
    }

};

int main()
{
  Time time;
  cout << time.getHour() << ":" << time.getMinute() << ":" << time.getSecond() << endl;

  Time time1(555550);
  cout << time1.getHour() << ":" << time1.getMinute() << ":" << time1.getSecond() << endl;

  return 0;
}


int time()
{
  int totalSeconds = time(0);

  int currentSecond = totalSeconds % 60;

  int totalMinutes = totalSeconds / 60;

  int currentMinute = totalMinutes % 60;

  int totalHours = totalMinutes / 60;

  int currentHour = totalHours % 24;

  return currentHour, currentMinute, currentSecond;
}

Ok so i have that so far.

The purpose of this code is to display the current time, and display the time if the seconds were 555550. The result should be something like:

Current Time is hh/mm/ss

Current Time for 555550 seconds is 10 hours, 19 minutes, 9 seconds.

I don't know where to go from here.

As with my other threads, any help deserves REP++

Mikey122687 · 2 Weeks Ago

K so i revised it and here is what i have now

PHP Code:


			
#include <iostream>
#include <ctime>
using namespace std;



class Time
{
public:
    int hour;
    int minute;
    int second;
    int time;

    Time()
    {
        time = time(0);
    }

    Time(int newTime)
    {
        time = newTime;
    }

    int getHour()
    {
        int totalSeconds = time(0);
        int currentSecond = totalSeconds % 60;
        int totalMinutes = totalSeconds / 60;
        int currentMinute = totalMinutes % 60;
        int totalHours = totalMinutes / 60;
        return totalHours;
    }

    int getMinute()
    {
         int totalSeconds = time(0);
         int currentSecond = totalSeconds % 60;
         int totalMinutes = totalSeconds / 60;
         int currentMinute = totalMinutes % 60;
         return currentMinute;
    }

     int getSecond()
    {
        int totalSeconds = time(0);
        int currentSecond = totalSeconds % 60;
        return currentSecond;
    }

};

int main()
{
  Time time;
  cout << time.getHour() << ":" << time.getMinute() << ":" << time.getSecond() << endl;

  Time time1(555550);
  cout << time1.getHour() << ":" << time1.getMinute() << ":" << time1.getSecond() << endl;

  return 0;
}

Mikey122687 · 2 Weeks Ago

Any suggestion as to what i should do next?

Korben · 2 Weeks Ago

Seems to work fine. I had to change the time(0) as time because they can't be used as functions.

Code:

#include <iostream>
#include <ctime>
using namespace std;



class Time
{
public:
    int hour;
    int minute;
    int second;
    int time;

    Time()
    {
        time = time;
    }

    Time(int newTime)
    {
        time = newTime;
    }

    int getHour()
    {
        int totalSeconds = time;
        int currentSecond = totalSeconds % 60;
        int totalMinutes = totalSeconds / 60;
        int currentMinute = totalMinutes % 60;
        int totalHours = totalMinutes / 60;
        return totalHours;
    }

    int getMinute()
    {
         int totalSeconds = time;
         int currentSecond = totalSeconds % 60;
         int totalMinutes = totalSeconds / 60;
         int currentMinute = totalMinutes % 60;
         return currentMinute;
    }

     int getSecond()
    {
        int totalSeconds = time;
        int currentSecond = totalSeconds % 60;
        return currentSecond;
    }

};

int main()
{
  Time time;
  cout << time.getHour() << ":" << time.getMinute() << ":" << time.getSecond() << endl;

  Time time1(555550);
  cout << time1.getHour() << ":" << time1.getMinute() << ":" << time1.getSecond() << endl;
  
  cin.get();
  return 0;
}

Spotswood · 2 Weeks Ago

Quote:

Originally Posted by Korben

Seems to work fine. I had to change the time(0) as time because they can't be used as functions.

That change negates the whole purpose of the class.

As written, the class's time data member clashes with the time() function. A better "fix" would be to rename the time data member to totalSeconds.

Don't re-fetch the the current time() in your class's member functions i.e. int a t1.getHour(); int b t1.getHour(); a should equal b.

Check your algorithms with simpler test code i.e. Time t(61); int h = t.getHour(); int m = t.getMinutes();, etc.

		Overclock.net - Overclocking.net > Software, Programming and Coding > Coding and Programming
C++: Class Time

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)