Overclock.net › Forums › Software, Programming and Coding › Coding and Programming › Web Coding › Can someone check my code:)?
New Posts  All Forums:Forum Nav:

Can someone check my code:)?

post #1 of 9
Thread Starter 
Hi Overclockek.net;)

If anyone has got like 5 mins to check my code (HTML + CSS) if you do post in this Thread and I'll Pm you with a link to the code.

Thanks
post #2 of 9
Why not just post it up here?
Daily
(16 items)
 
  
CPUMotherboardGraphicsRAM
i7 2600K @ 4.8GHz, 1.4V Maximus IV Extreme GTX 560 DCII TOP 4x4GB Kingston HyperX 1866MHz CL11 
Hard DriveHard DriveCoolingCooling
Kingston HyperX 3K 120GB Samsung 640GB Thermochill PA120.2 Jingway DB-1 Pump 
CoolingCoolingOSMonitor
2x Kaze Jyuni 1900RPM EK Supreme HF Copper plexi Arch Linux x64 Acer X223HQ 1920x1080 
KeyboardPowerCaseMouse
Microsoft Sidewinder X4 Corsair HX750 Modded Corsair Carbide 500R Logitech M500 
  hide details  
Reply
Daily
(16 items)
 
  
CPUMotherboardGraphicsRAM
i7 2600K @ 4.8GHz, 1.4V Maximus IV Extreme GTX 560 DCII TOP 4x4GB Kingston HyperX 1866MHz CL11 
Hard DriveHard DriveCoolingCooling
Kingston HyperX 3K 120GB Samsung 640GB Thermochill PA120.2 Jingway DB-1 Pump 
CoolingCoolingOSMonitor
2x Kaze Jyuni 1900RPM EK Supreme HF Copper plexi Arch Linux x64 Acer X223HQ 1920x1080 
KeyboardPowerCaseMouse
Microsoft Sidewinder X4 Corsair HX750 Modded Corsair Carbide 500R Logitech M500 
  hide details  
Reply
post #3 of 9
Thread Starter 
Ok:) There is where my code is. Thanks

http://jsfiddle.net/S8kra/
post #4 of 9
What is the problem you're having?
post #5 of 9
I dont see anything wrong with it... What are you asking?
My System
(20 items)
 
  
CPUMotherboardGraphicsGraphics
i5 Intel 2500K Gigabyte P67 UD7 B3 Sapphire 6970 2GB Sapphire 6970 2GB 
RAMHard DriveHard DriveCooling
Mushkin Black line 2133 Mhz 2x4GB 1TB Western Digital 120GB Corsair Force 3  XSPC EX240 
CoolingCoolingCoolingCooling
XSPC EX240 Swift Tech MCP655 XSPC Bay Res/ Pump EK Res 
CoolingOSMonitorKeyboard
Ice Dragon Coolant Windows 7 Ultimate 3x 22" Acer LED Monitor Apple Keyboard 
PowerCaseMouse
Corsair AX850 Corsair 600T SE White Modded Razer Naga 
  hide details  
Reply
My System
(20 items)
 
  
CPUMotherboardGraphicsGraphics
i5 Intel 2500K Gigabyte P67 UD7 B3 Sapphire 6970 2GB Sapphire 6970 2GB 
RAMHard DriveHard DriveCooling
Mushkin Black line 2133 Mhz 2x4GB 1TB Western Digital 120GB Corsair Force 3  XSPC EX240 
CoolingCoolingCoolingCooling
XSPC EX240 Swift Tech MCP655 XSPC Bay Res/ Pump EK Res 
CoolingOSMonitorKeyboard
Ice Dragon Coolant Windows 7 Ultimate 3x 22" Acer LED Monitor Apple Keyboard 
PowerCaseMouse
Corsair AX850 Corsair 600T SE White Modded Razer Naga 
  hide details  
Reply
post #6 of 9
Thread Starter 
Ah ok lads:) Someone told me the code was all wrong:/ so I just wanted to get it checked:).

Happy new year;)
post #7 of 9
Well, it is pretty unorganized. Right away, some things I notice are
  1. You have all your content inside your head tags. It should be in body tags instead.
  2. I would move the title to be there first thing inside your head tags.
  3. I would move the script to be after your css links.

So your code would be organized like so:
Code:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
    <title>Luke Hoare : My Portfolio</title>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
    <link rel="stylesheet" type="text/css" href="css/mainstylesheet.css" />
    <link rel="stylesheet" type="text/css" href="css/reset.css" />
    <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
</head>
<body>
    <div class="topleft">
        <a href="https://twitter.com/Luke_Hoare" class="twitter-follow-button" data-show-count="false">Follow @Luke_Hoare</a>
    </div>
    <div id="h1" class="round"> <! -- mis -- !>
    </div>
    <div id="h2" class="round">
        <center><img src="images/Site_banner.png" width="761" height="131" /> </center>
    </div>
    <div id="mainbox" class="round">
        <div id="links">
        <ul>
            <a href=""><font color="black">Home</a><hr>
            <a href=""><font color="black">About Me</a><hr>
            <a href=""><font color="black">Mis</a><hr>
            <a href=""><font color="black">Mis</a><hr>
            <a href=""><font color="black">Mis</a><hr>
            <a href=""><font color="black">Mis</a><hr>
        </ul>
        </div> 
    </div> 
    <p> Copyright - Luke Hoare </p>
</body>
</html>

Most of my suggestions are based on convention and personal preference, so don't take them as set-in-stone rules. smile.gif
Edited by Seventh Badger - 12/31/11 at 6:00pm
Viking
(13 items)
 
  
CPUMotherboardGraphicsRAM
Intel Core i5 2500K @ 4.8 GHz 1.45V P8Z68-V GEN3 [2x] EVGA GeForce GTX 570 SLI [2x] Kingston HyperX 4GB 1600MHz 
Hard DriveHard DriveCoolingCooling
Crucial M4 128GB [2x] WD 320GB XSPC Single Bay Reservoir Swiftech MCP655 
CoolingCoolingOSPower
XSPC Raystorm XSPC EX240 Windows 7 Pro 64-bit Corsair HX850 
Case
Corsair Obsidian 650D 
  hide details  
Reply
Viking
(13 items)
 
  
CPUMotherboardGraphicsRAM
Intel Core i5 2500K @ 4.8 GHz 1.45V P8Z68-V GEN3 [2x] EVGA GeForce GTX 570 SLI [2x] Kingston HyperX 4GB 1600MHz 
Hard DriveHard DriveCoolingCooling
Crucial M4 128GB [2x] WD 320GB XSPC Single Bay Reservoir Swiftech MCP655 
CoolingCoolingOSPower
XSPC Raystorm XSPC EX240 Windows 7 Pro 64-bit Corsair HX850 
Case
Corsair Obsidian 650D 
  hide details  
Reply
post #8 of 9
Thread Starter 
Ok mate thanks for the advice:) I have done everything you said apart from the script. Thanks:)
post #9 of 9
Technically you should make the charset declaration (the first meta tag in the head) before the title.

Also, the ul element stands for unordered list, and should contain child li elements, like so:
Code:
        <ul>
            <li><a href="#">Home</a></li>
            <li><a href="#">About Me</a></li>
        </ul>

The font coloring and styling relating to those horizontal rules could then be accomplished using external css, or at least proper inline styling (change font color="black" to style="color: black; border-bottom: solid 2px #000"). I would focus on getting the basics of your HTML structure down before diving into that however.

Here's a good place to start when you need a "code check": http://validator.w3.org/
New Posts  All Forums:Forum Nav:
  Return Home
  Back to Forum: Web Coding
Overclock.net › Forums › Software, Programming and Coding › Coding and Programming › Web Coding › Can someone check my code:)?