New Posts All Forums:Forum Nav:

Any idea of what's wrong with my tolower? (C code)

post #1 of 9

11/8/12 at 1:29pm

Thread Starter

Icekilla

Joined: Apr 2008
Location: Guadalajara, Mexico
Posts: 3,397
Rep: 93 (Unique: 81)
Select All Posts By This User

Here's my code

http://pastebin.com/hexSmDsG

The problem lies in the lines 23 and 33 (They're in fact, commented).

What I want is that once the string is read, it turns all of the characters to lowercase so it can be easier to search for the data, but so far, no luck.

Any help?

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

post #2 of 9

11/8/12 at 2:13pm

poroboszcz
PC Gamer

Joined: May 2008
Location: UK
Posts: 1,384
Rep: 82 (Unique: 58)
Select All Posts By This User

tolower() takes a single character and you'll passing it a char array. You need to iterate through characters in your string and convert each one individually.

CPU	Motherboard	Graphics	RAM
Intel i7-3820	ASrock X79 Extreme4	MSI GTX 660	G.Skill Ripjaws Z series
Hard Drive	Hard Drive	Hard Drive	Cooling
Samsung 830 SSD	Western Digital Caviar Black	Seagate 7200.12	Cooler Master Hyper 412
OS	Monitor	Monitor	Keyboard
Windows 7 Ultimate	Dell U2412M	Samsung 2253BW	Filco Majestouch-2
Power	Case	Mouse	Mouse Pad
Corsair VX 550 Watt	Fractal Design Define R2	Razer Deathadder	QPAD CT
Audio
Asus Xonar DX
View all

hide details

CPU	Motherboard	Graphics	RAM
Intel i7-3820	ASrock X79 Extreme4	MSI GTX 660	G.Skill Ripjaws Z series
Hard Drive	Hard Drive	Hard Drive	Cooling
Samsung 830 SSD	Western Digital Caviar Black	Seagate 7200.12	Cooler Master Hyper 412
OS	Monitor	Monitor	Keyboard
Windows 7 Ultimate	Dell U2412M	Samsung 2253BW	Filco Majestouch-2
Power	Case	Mouse	Mouse Pad
Corsair VX 550 Watt	Fractal Design Define R2	Razer Deathadder	QPAD CT
Audio
Asus Xonar DX
View all

hide details

post #3 of 9

11/8/12 at 2:30pm

Thread Starter

Icekilla

Joined: Apr 2008
Location: Guadalajara, Mexico
Posts: 3,397
Rep: 93 (Unique: 81)
Select All Posts By This User

Like this?

Code:

for(w=0;w<strlen(country[i]);w++)
         country[i]=tolower(country[w])

Then again, codeblocks kepes throwing errors.

EDIT: How about now?

http://pastebin.com/Yhj7wy6x
Edited by Icekilla - 11/8/12 at 3:14pm

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

post #4 of 9

11/18/12 at 8:35am

3930K
Programmer

Joined: Jan 2012
Location: Leeds, UK.
Posts: 5,813
Rep: 147 (Unique: 107)
Reviews: 1
Trader Rating: 1
Select All Posts By This User

http://codepad.org/C6sMqiKI

Gets you a line 69 error.

CPU	Motherboard	Graphics	RAM
[Intel] Core i7 3930K	[ASUS] RAMPAGE IV EXTREME	[EVGA] GeForce GTX 670 4GB SuperClocked+ with b...	[G.Skill] RipjawsZ 16GB 1866
Hard Drive	Hard Drive	Optical Drive	Cooling
[Samsung] 830 256GB	[Samsung] 840 500GB	[Sony] El cheapo CD reader	[Corsair] H100
Cooling	Cooling	OS	OS
4x [Corsair] Air Series SP120 High Performance	[Lamptron] FC6	[Microsoft] Windows 8 Pro x86-64	[Mint] Linux Mint 13 running on [Microsoft] HyperV
Monitor	Keyboard	Power	Case
[Dell] U2312HM	[Razer] BlackWidow	[Corsair] AX750	[NZXT] Switch 810
Mouse	Mouse Pad	Audio	Audio
[Corsair] M60	[IKEA] Table.	[ASUS] Xonar DX	[Creative] T3130
Audio
[JVC] HA-RX700
View all

hide details

CPU	Motherboard	Graphics	RAM
[Intel] Core i7 3930K	[ASUS] RAMPAGE IV EXTREME	[EVGA] GeForce GTX 670 4GB SuperClocked+ with b...	[G.Skill] RipjawsZ 16GB 1866
Hard Drive	Hard Drive	Optical Drive	Cooling
[Samsung] 830 256GB	[Samsung] 840 500GB	[Sony] El cheapo CD reader	[Corsair] H100
Cooling	Cooling	OS	OS
4x [Corsair] Air Series SP120 High Performance	[Lamptron] FC6	[Microsoft] Windows 8 Pro x86-64	[Mint] Linux Mint 13 running on [Microsoft] HyperV
Monitor	Keyboard	Power	Case
[Dell] U2312HM	[Razer] BlackWidow	[Corsair] AX750	[NZXT] Switch 810
Mouse	Mouse Pad	Audio	Audio
[Corsair] M60	[IKEA] Table.	[ASUS] Xonar DX	[Creative] T3130
Audio
[JVC] HA-RX700
View all

hide details

post #5 of 9

11/18/12 at 9:05pm

Thread Starter

Icekilla

Joined: Apr 2008
Location: Guadalajara, Mexico
Posts: 3,397
Rep: 93 (Unique: 81)
Select All Posts By This User

How about now? Running it in CodeBlocks seems decent.

http://pastebin.com/TsRakggL

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

post #6 of 9

11/18/12 at 9:21pm

lordikon
Game Programmer

Joined: Feb 2008
Location: Denver, CO
Posts: 12,752
Rep: 822 (Unique: 562)
Trader Rating: 1
Select All Posts By This User

Quote:

Originally Posted by Icekilla

How about now? Running it in CodeBlocks seems decent.

http://pastebin.com/TsRakggL

You should not declare variables outside of the scope that they are needed, or before they are needed. You should give variables useful names so people can easily know what they're being used for. You should not declare more than one variable per line.

You're using the second dimension of your array 'country' before it is initialized to anything. You're also using the first dimension in that array unsafely. Generally you will want to initialize each index in the array to a default value, often zero. You can use memset to do this since the array is using a primitive data type. I would work on getting the array properly initialized and filled with data and then the tolower should work.

CPU	Motherboard	Graphics	Graphics
i7 950	EVGA x58 3-way SLI	EVGA GTX 660ti	GTX 275
RAM	Hard Drive	Hard Drive	Hard Drive
3x2GB Corsair Dominator DDR3-1600	80GB Intel X25-M SSD	2TB WD Black	150GB WD Raptor
Hard Drive	OS	Monitor	Keyboard
2x 150GB WD V-raptor in RAID0	Win7 Home 64-bit OEM	55" LED 120hz 1080p Vizio	MS Natural Ergonomic Keyboard 4000
Power	Case
750W PC P&C Silencer	CoolerMaster 690
View all

CPU	Graphics	RAM	Hard Drive
Intel Core i5 2500S	AMD 6770M	8GB (2x4GB) at 1333Mhz	1TB, 7200 rpm
Optical Drive	OS	Monitor	Keyboard
LG 8X Dual-Layer "SuperDrive"	OS X Lion	27" iMac screen	Mac wireless keyboard
Mouse
Mac wireless mouse
View all

CPU	Graphics	RAM	Hard Drive
i7-2600K	AMD 6970M 1GB	16GB PC3-10600 DDR3	1TB 7200rpm
Hard Drive	Optical Drive	OS	Monitor
256GB SSD	8x DL "SuperDrive"	OS X 10.7 Lion	27" 2560x1440 iMac display
Monitor
27" Apple thunderbolt display
View all

hide details

CPU	Motherboard	Graphics	Graphics
i7 950	EVGA x58 3-way SLI	EVGA GTX 660ti	GTX 275
RAM	Hard Drive	Hard Drive	Hard Drive
3x2GB Corsair Dominator DDR3-1600	80GB Intel X25-M SSD	2TB WD Black	150GB WD Raptor
Hard Drive	OS	Monitor	Keyboard
2x 150GB WD V-raptor in RAID0	Win7 Home 64-bit OEM	55" LED 120hz 1080p Vizio	MS Natural Ergonomic Keyboard 4000
Power	Case
750W PC P&C Silencer	CoolerMaster 690
View all

CPU	Graphics	RAM	Hard Drive
Intel Core i5 2500S	AMD 6770M	8GB (2x4GB) at 1333Mhz	1TB, 7200 rpm
Optical Drive	OS	Monitor	Keyboard
LG 8X Dual-Layer "SuperDrive"	OS X Lion	27" iMac screen	Mac wireless keyboard
Mouse
Mac wireless mouse
View all

CPU	Graphics	RAM	Hard Drive
i7-2600K	AMD 6970M 1GB	16GB PC3-10600 DDR3	1TB 7200rpm
Hard Drive	Optical Drive	OS	Monitor
256GB SSD	8x DL "SuperDrive"	OS X 10.7 Lion	27" 2560x1440 iMac display
Monitor
27" Apple thunderbolt display
View all

hide details

post #7 of 9

11/18/12 at 9:28pm

Thread Starter

Icekilla

Joined: Apr 2008
Location: Guadalajara, Mexico
Posts: 3,397
Rep: 93 (Unique: 81)
Select All Posts By This User

The thing is, everything is working now... Should I still optimize it, though?

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

post #8 of 9

11/18/12 at 9:32pm

lordikon
Game Programmer

Joined: Feb 2008
Location: Denver, CO
Posts: 12,752
Rep: 822 (Unique: 562)
Trader Rating: 1
Select All Posts By This User

Quote:

Originally Posted by Icekilla

The thing is, everything is working now... Should I still optimize it, though?

If it's never going to be used again or by anyone else, then I wouldn't clean it up unless you want to do it for practice.

CPU	Motherboard	Graphics	Graphics
i7 950	EVGA x58 3-way SLI	EVGA GTX 660ti	GTX 275
RAM	Hard Drive	Hard Drive	Hard Drive
3x2GB Corsair Dominator DDR3-1600	80GB Intel X25-M SSD	2TB WD Black	150GB WD Raptor
Hard Drive	OS	Monitor	Keyboard
2x 150GB WD V-raptor in RAID0	Win7 Home 64-bit OEM	55" LED 120hz 1080p Vizio	MS Natural Ergonomic Keyboard 4000
Power	Case
750W PC P&C Silencer	CoolerMaster 690
View all

CPU	Graphics	RAM	Hard Drive
Intel Core i5 2500S	AMD 6770M	8GB (2x4GB) at 1333Mhz	1TB, 7200 rpm
Optical Drive	OS	Monitor	Keyboard
LG 8X Dual-Layer "SuperDrive"	OS X Lion	27" iMac screen	Mac wireless keyboard
Mouse
Mac wireless mouse
View all

CPU	Graphics	RAM	Hard Drive
i7-2600K	AMD 6970M 1GB	16GB PC3-10600 DDR3	1TB 7200rpm
Hard Drive	Optical Drive	OS	Monitor
256GB SSD	8x DL "SuperDrive"	OS X 10.7 Lion	27" 2560x1440 iMac display
Monitor
27" Apple thunderbolt display
View all

hide details

CPU	Motherboard	Graphics	Graphics
i7 950	EVGA x58 3-way SLI	EVGA GTX 660ti	GTX 275
RAM	Hard Drive	Hard Drive	Hard Drive
3x2GB Corsair Dominator DDR3-1600	80GB Intel X25-M SSD	2TB WD Black	150GB WD Raptor
Hard Drive	OS	Monitor	Keyboard
2x 150GB WD V-raptor in RAID0	Win7 Home 64-bit OEM	55" LED 120hz 1080p Vizio	MS Natural Ergonomic Keyboard 4000
Power	Case
750W PC P&C Silencer	CoolerMaster 690
View all

CPU	Graphics	RAM	Hard Drive
Intel Core i5 2500S	AMD 6770M	8GB (2x4GB) at 1333Mhz	1TB, 7200 rpm
Optical Drive	OS	Monitor	Keyboard
LG 8X Dual-Layer "SuperDrive"	OS X Lion	27" iMac screen	Mac wireless keyboard
Mouse
Mac wireless mouse
View all

CPU	Graphics	RAM	Hard Drive
i7-2600K	AMD 6970M 1GB	16GB PC3-10600 DDR3	1TB 7200rpm
Hard Drive	Optical Drive	OS	Monitor
256GB SSD	8x DL "SuperDrive"	OS X 10.7 Lion	27" 2560x1440 iMac display
Monitor
27" Apple thunderbolt display
View all

hide details

post #9 of 9

11/18/12 at 9:38pm

Thread Starter

Icekilla

Joined: Apr 2008
Location: Guadalajara, Mexico
Posts: 3,397
Rep: 93 (Unique: 81)
Select All Posts By This User

It's just for a homework, but I guess it'd be a good practice.

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

CPU	Motherboard	Graphics	RAM
Intel Core i5 2500k	Gigabyte GA-Z77-D3H	EVGA GTX 660ti SuperClocked	PNY Optima MD4096SD3-1333
Hard Drive	Hard Drive	Hard Drive	Optical Drive
Western Digital WD500AAKX 500GB SATA	Seagate ST2000DL003	ADATA AS510S3-120GM-C 120GB SSD	Lite-On iHAS224-06
Cooling	OS	Monitor	Monitor
Cooler Master Hyper 212+	Windows 7 Ultimate x64	Samsung B1930	Benq G92HDA
Power	Case	Audio
Corsair TX750 750W PSU	Gray Acteck Octanux	Logitech Z623 2.1CH
View all

hide details

Start a New Thread

Subscribe Search This Thread

New Posts All Forums:Forum Nav:

Return Home

Back to Forum: Coding and Programming

Forums
Software, Programming and Coding
Coding and Programming
Any idea of what's wrong with my tolower? (C code)

I honestly love this cooler, but I think I'm gonna move on to another one soon, it just looks... A bit to bland compared to other flaming red (literally) coolers on the market.

Metro 2033 is one of the greatest FPS games ever made. Although not usually recognized as such, due to the horrible state the gaming industry is in, it succeeds largely on its storytelling,...

This is an update of the original Fractal Design Arc Midi. The solid left panel has been replaced by a panel with a plexiglass window and the top USB ports are now USB-3.0. Let me state at the...

I've used this headset extensively for MAG on PS3. The sounds were wonderful, the mic was crisp, and the ability to adjust peoples voice volume is absolutely invaluable. For $100 ( or less ) this...

The Pros The reason this card is one of the better non-Tahiti 7870s is because of Gigabyte's custom PCB. Gigabyte took the 7870 and replaced it's memory chips with Hynix memory so they perform a...

Recent Reviews

Any idea of what's wrong with my tolower? (C code)

Recent Discussions

Recent Reviews

New Articles

Featured Sponsors

Recent Reviews

Any idea of what's wrong with my tolower? (C code)

Recent Discussions

Recent Reviews

New Articles